Re: [PATCH 1/6] t0021/rot13-filter: refactor packet reading functions

2017-11-05 Thread Christian Couder
On Sun, Oct 22, 2017 at 2:58 AM, Junio C Hamano wrote: > Christian Couder writes: > >> To make it possible in a following commit to move packet >> reading and writing functions into a Packet.pm module, >> let's refactor these functions, so they don't handle >> printing debug output and exiting. >

Re: [PATCH 1/6] t0021/rot13-filter: refactor packet reading functions

2017-10-21 Thread Junio C Hamano
Christian Couder writes: > To make it possible in a following commit to move packet > reading and writing functions into a Packet.pm module, > let's refactor these functions, so they don't handle > printing debug output and exiting. > > Signed-off-by: Christian Couder > --- > t/t0021/rot13-filt

Re: [PATCH 1/6] t0021/rot13-filter: refactor packet reading functions

2017-10-19 Thread Stefan Beller
On Thu, Oct 19, 2017 at 5:30 AM, Christian Couder wrote: > To make it possible in a following commit to move packet > reading and writing functions into a Packet.pm module, > let's refactor these functions, so they don't handle > printing debug output and exiting. > > Signed-off-by: Christian Coud

[PATCH 1/6] t0021/rot13-filter: refactor packet reading functions

2017-10-19 Thread Christian Couder
To make it possible in a following commit to move packet reading and writing functions into a Packet.pm module, let's refactor these functions, so they don't handle printing debug output and exiting. Signed-off-by: Christian Couder --- t/t0021/rot13-filter.pl | 12 1 file changed, 8