[PATCH 1/8] Use %B for Split Subject/Body

2012-12-31 Thread David A. Greene
From: Techlive Zheng Use %B to format the commit message and body to avoid an extra newline if a commit only has a subject line. Author:Techlive Zheng Signed-off-by: David A. Greene --- contrib/subtree/git-subtree.sh |5 +++ contrib/subtree/t/t7900-subtree.sh | 73 +

Re: [PATCH 1/8] Use %B for Split Subject/Body

2012-12-31 Thread greened
"David A. Greene" writes: > From: Techlive Zheng > > Use %B to format the commit message and body to avoid an extra newline > if a commit only has a subject line. Wow. So that was a spectacular fail. Sorry about th duplicate patch e-mails. I have no idea how that happened.

Re: [PATCH 1/8] Use %B for Split Subject/Body

2012-12-31 Thread Junio C Hamano
"David A. Greene" writes: > From: Techlive Zheng > > Use %B to format the commit message and body to avoid an extra newline > if a commit only has a subject line. Is this an unconditional improvement, or is it generally an improvement but for some users it may be a regression? I am guessing it

Re: [PATCH 1/8] Use %B for Split Subject/Body

2012-12-31 Thread Junio C Hamano
gree...@obbligato.org writes: > "David A. Greene" writes: > >> From: Techlive Zheng >> >> Use %B to format the commit message and body to avoid an extra newline >> if a commit only has a subject line. > > Wow. So that was a spectacular fail. Sorry about th duplicate patch > e-mails. I have no

Re: [PATCH 1/8] Use %B for Split Subject/Body

2013-01-01 Thread Junio C Hamano
"David A. Greene" writes: > Subject: Re: [PATCH 1/8] Use %B for Split Subject/Body This needs to say "contrib/subtree" somewhere (applies to all patches in this series). > From: Techlive Zheng > > Use %B to format the commit message and body to avoid an extra

Re: [PATCH 1/8] Use %B for Split Subject/Body

2013-01-01 Thread greened
Junio C Hamano writes: > "David A. Greene" writes: > >> From: Techlive Zheng >> >> Use %B to format the commit message and body to avoid an extra newline >> if a commit only has a subject line. > > Is this an unconditional improvement, or is it generally an > improvement but for some users it m

Re: [PATCH 1/8] Use %B for Split Subject/Body

2013-01-01 Thread greened
Junio C Hamano writes: > Also, please be careful about the subject line. I doubt that these > 8 patches will stand out as relating to "contrib/subtree", when mixed > in 200 line output of "git shortlog --no-merges". Ah, ok. I'll be more careful next time. -David -- T

Re: [PATCH 1/8] Use %B for Split Subject/Body

2013-01-01 Thread greened
Junio C Hamano writes: > "David A. Greene" writes: > >> Subject: Re: [PATCH 1/8] Use %B for Split Subject/Body > > This needs to say "contrib/subtree" somewhere (applies to all > patches in this series). Ok. Shall I re-send everything? >> F

Re: [PATCH 1/8] Use %B for Split Subject/Body

2013-01-01 Thread Junio C Hamano
gree...@obbligato.org writes: > Ack, of course. I don't know how I missed that. > >>> # 15 >>> test_expect_success 'add main6' ' >>> create main6 && >> >> Why? > > It was in the original testsuite from Avery. I didn't add or remove any > tests when I first integrated git-subtree. The

Re: [PATCH 1/8] Use %B for Split Subject/Body

2013-01-07 Thread Techlive Zheng
2013/1/1 Junio C Hamano : > "David A. Greene" writes: > >> From: Techlive Zheng >> >> Use %B to format the commit message and body to avoid an extra newline >> if a commit only has a subject line. > > Is this an unconditional improvement, or is it generally an > improvement but for some users it

Re: [PATCH 1/8] Use %B for Split Subject/Body

2013-01-07 Thread Techlive Zheng
2013/1/1 Junio C Hamano : > "David A. Greene" writes: > >> From: Techlive Zheng >> >> Use %B to format the commit message and body to avoid an extra newline >> if a commit only has a subject line. > > Is this an unconditional improvement, or is it generally an > improvement but for some users it

Re: [PATCH 1/8] Use %B for Split Subject/Body

2013-01-07 Thread Junio C Hamano
"郑文辉(Techlive Zheng)" writes: > Though, this patch defintely should be merged, becuase no one expects > his commit message be altered durging the splitting process. Are you saying that after double-checking what was posted? It said something like this below, which does not look like 'definitel

Re: [PATCH 1/8] Use %B for Split Subject/Body

2013-01-08 Thread greened
Junio C Hamano writes: > The question was about the lossage of the blank line, which does not > seem to be related to what this patch wants to do. Ah, missed that. -# 25 +#25 >>> >>> Why the lossage of a SP? >> >> I think this got fixed later in the series. > > That is not a good excu