Re: [PATCH 1/8] builtin/receive-pack: use check_signature from gpg-interface

2018-07-09 Thread Junio C Hamano
Henning Schild writes: > I think 1 and 2 can be seen as somewhat unrelated to the gpgsm feature, > they are more general refactoring. So i think picking them is a good > idea. It will make the series shorter and ease review in the next round. Surely, resending from patch 3 and upwards labelled a

Re: [PATCH 1/8] builtin/receive-pack: use check_signature from gpg-interface

2018-07-09 Thread Henning Schild
Am Fri, 6 Jul 2018 14:35:29 -0700 schrieb Junio C Hamano : > Junio C Hamano writes: > > > Henning Schild writes: > > > >> The combination of verify_signed_buffer followed by > >> parse_gpg_output is available as check_signature. Use that instead > >> of implementing it again. > >> > >> Signed

Re: [PATCH 1/8] builtin/receive-pack: use check_signature from gpg-interface

2018-07-06 Thread Junio C Hamano
Junio C Hamano writes: > Henning Schild writes: > >> The combination of verify_signed_buffer followed by parse_gpg_output is >> available as check_signature. Use that instead of implementing it again. >> >> Signed-off-by: Henning Schild >> --- > > Makes sense. > > When d05b9618 ("receive-pack

Re: [PATCH 1/8] builtin/receive-pack: use check_signature from gpg-interface

2018-07-06 Thread Junio C Hamano
Henning Schild writes: > The combination of verify_signed_buffer followed by parse_gpg_output is > available as check_signature. Use that instead of implementing it again. > > Signed-off-by: Henning Schild > --- Makes sense. When d05b9618 ("receive-pack: GPG-validate push certificates", 2014

[PATCH 1/8] builtin/receive-pack: use check_signature from gpg-interface

2018-07-03 Thread Henning Schild
The combination of verify_signed_buffer followed by parse_gpg_output is available as check_signature. Use that instead of implementing it again. Signed-off-by: Henning Schild --- builtin/receive-pack.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/builtin