Re: [PATCH 1/9] Makefile: add a hdr-check target

2018-09-20 Thread Junio C Hamano
Ramsay Jones writes: > Yes, this was one of my first concerns (I even asked Elijah what > compiler options he used), but I was getting useful results without > passing CFLAGS, so I just ignored that issue ... :-D > ... > Indeed. This bothered me as well. The 'compat' directory does not > follow

Re: [PATCH 1/9] Makefile: add a hdr-check target

2018-09-20 Thread Ramsay Jones
On 20/09/18 15:26, Junio C Hamano wrote: > Ramsay Jones writes: > >> Commit ef3ca95475 ("Add missing includes and forward declarations", >> 2018-08-15) resulted from the author employing a manual method to >> create a C file consisting of a pair of pre-processor #include >> lines (for

Re: [PATCH 1/9] Makefile: add a hdr-check target

2018-09-20 Thread Junio C Hamano
Ramsay Jones writes: > Commit ef3ca95475 ("Add missing includes and forward declarations", > 2018-08-15) resulted from the author employing a manual method to > create a C file consisting of a pair of pre-processor #include > lines (for 'git-compat-util.h' and a given toplevel header), and >

Re: [PATCH 1/9] Makefile: add a hdr-check target

2018-09-19 Thread Martin Ågren
On Wed, 19 Sep 2018 at 22:15, Ramsay Jones wrote: > On 19/09/18 18:49, Martin Ågren wrote: > > On Wed, 19 Sep 2018 at 02:07, Ramsay Jones > > wrote: > >> +GEN_HDRS := command-list.h unicode-width.h > > > > Most of the things happening around here are obvious steps towards the > > end-goal and

Re: [PATCH 1/9] Makefile: add a hdr-check target

2018-09-19 Thread Ramsay Jones
On 19/09/18 18:49, Martin Ågren wrote: > Hi Ramsay, > > On Wed, 19 Sep 2018 at 02:07, Ramsay Jones > wrote: >> @@ -2675,6 +2676,17 @@ $(SP_OBJ): %.sp: %.c GIT-CFLAGS FORCE >> .PHONY: sparse $(SP_OBJ) >> sparse: $(SP_OBJ) >> >> +GEN_HDRS := command-list.h unicode-width.h > > Most of the

Re: [PATCH 1/9] Makefile: add a hdr-check target

2018-09-19 Thread Martin Ågren
Hi Ramsay, On Wed, 19 Sep 2018 at 02:07, Ramsay Jones wrote: > @@ -2675,6 +2676,17 @@ $(SP_OBJ): %.sp: %.c GIT-CFLAGS FORCE > .PHONY: sparse $(SP_OBJ) > sparse: $(SP_OBJ) > > +GEN_HDRS := command-list.h unicode-width.h Most of the things happening around here are obvious steps towards the

[PATCH 1/9] Makefile: add a hdr-check target

2018-09-18 Thread Ramsay Jones
Commit ef3ca95475 ("Add missing includes and forward declarations", 2018-08-15) resulted from the author employing a manual method to create a C file consisting of a pair of pre-processor #include lines (for 'git-compat-util.h' and a given toplevel header), and fixing any resulting compiler