Re: [PATCH 1/9] submodule-config: "goto" removal in parse_config()

2015-10-27 Thread Junio C Hamano
Jonathan Nieder writes: > Not having read the patch yet, the above makes me suspect this is > going to make the code worse. A 'goto' for exception handling can > be a clean way to ensure everything allocated gets released, and > restructuring to avoid that can end up making the code more error >

Re: [PATCH 1/9] submodule-config: "goto" removal in parse_config()

2015-10-27 Thread Jonathan Nieder
Hi, Stefan Beller wrote: > Subject: submodule-config: "goto" removal in parse_config() > > Many components in if/else if/... cascade jumped to a shared > clean-up with "goto release_return", but we can restructure the > function a bit and make them disappear, Not having read the patch yet, the a

[PATCH 1/9] submodule-config: "goto" removal in parse_config()

2015-10-27 Thread Stefan Beller
Many components in if/else if/... cascade jumped to a shared clean-up with "goto release_return", but we can restructure the function a bit and make them disappear, which reduces the line count as well. Also reformat overlong lines and poorly indented ones while at it. The order of rules to verif