Re: [PATCH 10/15] commit.c: fix a memory leak

On Sat, Mar 21, 2015 at 10:59 AM, Junio C Hamano gits...@pobox.com wrote: A further tangent (Duy Cc'ed for this point). We might want to rethink the interface to ce_path_match() and report_path_error() so that we do not have to do a separate allocation of has this pathspec been used? array.

Re* [PATCH 10/15] commit.c: fix a memory leak

Duy Nguyen pclo...@gmail.com writes: On Sat, Mar 21, 2015 at 10:59 AM, Junio C Hamano gits...@pobox.com wrote: A further tangent (Duy Cc'ed for this point). We might want to rethink the interface to ce_path_match() and report_path_error() so that we do not have to do a separate allocation of

Re: Re* [PATCH 10/15] commit.c: fix a memory leak

On Tue, Mar 24, 2015 at 2:17 PM, Junio C Hamano gits...@pobox.com wrote: Move it to dir.c where match_pathspec() is defined. Signed-off-by: Junio C Hamano gits...@pobox.com Reviewed-by: Stefan Beller sbel...@google.com -- To unsubscribe from this list: send the line unsubscribe git in the

[PATCH 10/15] commit.c: fix a memory leak

Signed-off-by: Stefan Beller sbel...@google.com --- builtin/commit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/builtin/commit.c b/builtin/commit.c index 961e467..da79ac4 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -229,7 +229,7 @@ static int

Re: [PATCH 10/15] commit.c: fix a memory leak

Stefan Beller sbel...@google.com writes: Signed-off-by: Stefan Beller sbel...@google.com --- builtin/commit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/builtin/commit.c b/builtin/commit.c index 961e467..da79ac4 100644 --- a/builtin/commit.c +++