Re: [PATCH 10/35] commit: add repository argument to lookup_commit

2018-06-14 Thread Brandon Williams
On 06/14, Stefan Beller wrote: > On Thu, Jun 14, 2018 at 9:22 AM Duy Nguyen wrote: > > > > On Wed, May 30, 2018 at 2:51 AM Stefan Beller wrote: > > > diff --git a/shallow.c b/shallow.c > > > index 9bb07a56dca..60fe1fe1e58 100644 > > > --- a/shallow.c > > > +++ b/shallow.c > > > @@ -31,7 +31,7 @@

Re: [PATCH 10/35] commit: add repository argument to lookup_commit

2018-06-14 Thread Stefan Beller
On Thu, Jun 14, 2018 at 9:22 AM Duy Nguyen wrote: > > On Wed, May 30, 2018 at 2:51 AM Stefan Beller wrote: > > diff --git a/shallow.c b/shallow.c > > index 9bb07a56dca..60fe1fe1e58 100644 > > --- a/shallow.c > > +++ b/shallow.c > > @@ -31,7 +31,7 @@ int register_shallow(struct repository *r,

Re: [PATCH 10/35] commit: add repository argument to lookup_commit

2018-06-14 Thread Duy Nguyen
On Wed, May 30, 2018 at 2:51 AM Stefan Beller wrote: > diff --git a/shallow.c b/shallow.c > index 9bb07a56dca..60fe1fe1e58 100644 > --- a/shallow.c > +++ b/shallow.c > @@ -31,7 +31,7 @@ int register_shallow(struct repository *r, const struct > object_id *oid) > { > struct commit_graft

[PATCH 10/35] commit: add repository argument to lookup_commit

2018-05-29 Thread Stefan Beller
Add a repository argument to allow callers of lookup_commit to be more specific about which repository to handle. This is a small mechanical change; it doesn't change the implementation to handle repositories other than the_repository yet. As with the previous commits, use a macro to catch