Re: [PATCH 10/38] pack v4: commit object encoding

2013-09-06 Thread Nicolas Pitre
On Fri, 6 Sep 2013, Junio C Hamano wrote: > Nicolas Pitre writes: > > > OK. If I understand correctly, the committer time stamp is more > > important than the author's, right? > > Yeah, it matters a lot more when doing timestamp based traversal > without the reachability bitmaps. > > > ... m

Re: [PATCH 10/38] pack v4: commit object encoding

2013-09-06 Thread Junio C Hamano
Nicolas Pitre writes: > OK. If I understand correctly, the committer time stamp is more > important than the author's, right? Yeah, it matters a lot more when doing timestamp based traversal without the reachability bitmaps. > ... may I suggest keeping the tree reference first. That > is ea

Re: [PATCH 10/38] pack v4: commit object encoding

2013-09-06 Thread Nicolas Pitre
On Thu, 5 Sep 2013, Junio C Hamano wrote: > Nicolas Pitre writes: > > > This goes as follows: > > > > - Tree reference: either variable length encoding of the index > > into the SHA1 table or the literal SHA1 prefixed by 0 (see > > encode_sha1ref()). > > > > - Parent count: variable length e

Re: [PATCH 10/38] pack v4: commit object encoding

2013-09-05 Thread Junio C Hamano
Nicolas Pitre writes: > This goes as follows: > > - Tree reference: either variable length encoding of the index > into the SHA1 table or the literal SHA1 prefixed by 0 (see > encode_sha1ref()). > > - Parent count: variable length encoding of the number of parents. > This is normally going

[PATCH 10/38] pack v4: commit object encoding

2013-09-04 Thread Nicolas Pitre
This goes as follows: - Tree reference: either variable length encoding of the index into the SHA1 table or the literal SHA1 prefixed by 0 (see encode_sha1ref()). - Parent count: variable length encoding of the number of parents. This is normally going to occupy a single byte but doesn't ha