Re: [PATCH 11/11] builtin rebase: support `git rebase `

2018-08-08 Thread Johannes Schindelin
Hi Duy, On Wed, 8 Aug 2018, Duy Nguyen wrote: > On Wed, Aug 8, 2018 at 3:55 PM Pratik Karki wrote: > > > > diff --git a/builtin/rebase.c b/builtin/rebase.c > > index 63634210c0..b2ddfa8dbf 100644 > > --- a/builtin/rebase.c > > +++ b/builtin/rebase.c > > @@ -585,7 +602,8 @@ int cmd_rebase(int

Re: [PATCH 11/11] builtin rebase: support `git rebase `

2018-08-08 Thread Duy Nguyen
(not really a review, this patch just happens to catch my eyes) On Wed, Aug 8, 2018 at 3:55 PM Pratik Karki wrote: > > This commit adds support for `switch-to` which is used to switch to the > target branch if needed. The equivalent codes found in shell script > `git-legacy-rebase.sh` is

[PATCH 11/11] builtin rebase: support `git rebase `

2018-08-08 Thread Pratik Karki
This commit adds support for `switch-to` which is used to switch to the target branch if needed. The equivalent codes found in shell script `git-legacy-rebase.sh` is converted to builtin `rebase.c`. Signed-off-by: Pratik Karki --- builtin/rebase.c | 48