Re: [PATCH 11/11] read_cache: convert most calls to repo_read_index_or_die

On Wed, May 16, 2018 at 03:27:33PM -0700, Brandon Williams wrote: > Maybe we can kill read_cache() while at it? I took this out of context. But with the move to repo_* stuff, eventually these macros around the_index should die. Not today though. -- Duy

Re: [PATCH 11/11] read_cache: convert most calls to repo_read_index_or_die

On Wed, May 16, 2018 at 03:21:18PM -0700, Stefan Beller wrote: This commit may need some more explanation. It's not always safe to replace "read_cache();" with "repo_read_index_or_die();" and you do sometimes avoid that variant. While I agree _or_die() is the right thing to do most of the time.

Re: [PATCH 11/11] read_cache: convert most calls to repo_read_index_or_die

On 05/16, Stefan Beller wrote: > Signed-off-by: Stefan Beller > --- > blame.c | 5 +++-- > builtin/am.c | 3 ++- > builtin/diff.c| 3 ++- > builtin/fsck.c| 3 ++- > builtin/merge-index.c | 3 ++- > check-racy.c | 2 +- > diff.c

[PATCH 11/11] read_cache: convert most calls to repo_read_index_or_die

Signed-off-by: Stefan Beller --- blame.c | 5 +++-- builtin/am.c | 3 ++- builtin/diff.c| 3 ++- builtin/fsck.c| 3 ++- builtin/merge-index.c | 3 ++- check-racy.c | 2 +- diff.c| 5 +++-- merge-recursive.c |