Re: [PATCH 11/23] files_transaction_cleanup(): new helper function

2017-05-18 Thread Michael Haggerty
On 05/17/2017 03:19 PM, Jeff King wrote: > On Wed, May 17, 2017 at 02:05:34PM +0200, Michael Haggerty wrote: > >> Extract function from `files_transaction_commit()`. It will soon have >> another caller. >> [...] >> @@ -2868,10 +2889,8 @@ static int files_transaction_commit(struct ref_store >> *re

Re: [PATCH 11/23] files_transaction_cleanup(): new helper function

2017-05-18 Thread Michael Haggerty
On 05/17/2017 07:26 PM, Stefan Beller wrote: > On Wed, May 17, 2017 at 5:05 AM, Michael Haggerty > wrote: >> Extract function from `files_transaction_commit()`. It will soon have >> another caller. > > This sounds odd to me. Maybe it is missing words? > of s/function/the functionality to cleanup

Re: [PATCH 11/23] files_transaction_cleanup(): new helper function

2017-05-17 Thread Stefan Beller
On Wed, May 17, 2017 at 5:05 AM, Michael Haggerty wrote: > Extract function from `files_transaction_commit()`. It will soon have > another caller. This sounds odd to me. Maybe it is missing words? of s/function/the functionality to cleanup/ Code makes sense to me. Stefan

Re: [PATCH 11/23] files_transaction_cleanup(): new helper function

2017-05-17 Thread Jeff King
On Wed, May 17, 2017 at 02:05:34PM +0200, Michael Haggerty wrote: > Extract function from `files_transaction_commit()`. It will soon have > another caller. > [...] > @@ -2868,10 +2889,8 @@ static int files_transaction_commit(struct ref_store > *ref_store, > if (transaction->state != REF_TRA

[PATCH 11/23] files_transaction_cleanup(): new helper function

2017-05-17 Thread Michael Haggerty
Extract function from `files_transaction_commit()`. It will soon have another caller. Signed-off-by: Michael Haggerty --- refs/files-backend.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/refs/files-backend.c b/refs/files-backend.c index