Re: [PATCH 12/13] dir_iterator: new API for iterating over a directory tree

2016-06-03 Thread Michael Haggerty
On 06/01/2016 02:12 AM, David Turner wrote: > On Mon, 2016-05-30 at 09:55 +0200, Michael Haggerty wrote: >> +struct dir_iterator_level { >> +int initialized; >> + >> +DIR *dir; >> + >> +/* >> + * The length of the directory part of refname at this level > > > "refname"? Isn't

Re: [PATCH 12/13] dir_iterator: new API for iterating over a directory tree

2016-05-31 Thread David Turner
On Mon, 2016-05-30 at 09:55 +0200, Michael Haggerty wrote: > +struct dir_iterator_level { > + int initialized; > + > + DIR *dir; > + > + /* > + * The length of the directory part of refname at this level "refname"? Isn't this was for directories? > + if

[PATCH 12/13] dir_iterator: new API for iterating over a directory tree

2016-05-30 Thread Michael Haggerty
The iterator interface is modeled on that for references, though no vtable is necessary because there is (so far?) only one type of dir_iterator. There are obviously a lot of features that could easily be added to this class: * Skip/include directory paths in the iteration * Shallow/deep