Re: [PATCH 13/21] fast-import: simplify allocation in start_packfile

2016-02-19 Thread Jeff King
On Fri, Feb 19, 2016 at 09:48:54AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > This function allocate a packed_git flex-array, and adds a > > s/allocate//, right? Yes, thanks. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a

Re: [PATCH 13/21] fast-import: simplify allocation in start_packfile

2016-02-19 Thread Junio C Hamano
Jeff King writes: > This function allocate a packed_git flex-array, and adds a s/allocate//, right? > mysterious 2 bytes to the length of the pack_name field. One > is for the trailing NUL, but the other has no purpose. This > is probably cargo-culted from add_packed_git, which

[PATCH 13/21] fast-import: simplify allocation in start_packfile

2016-02-19 Thread Jeff King
This function allocate a packed_git flex-array, and adds a mysterious 2 bytes to the length of the pack_name field. One is for the trailing NUL, but the other has no purpose. This is probably cargo-culted from add_packed_git, which gets the ".idx" path and needed to allocate enough space to hold