Re: [PATCH 15/13] compat/fnmatch: fix off-by-one character class's length check

2012-11-19 Thread Johannes Sixt
Am 11/11/2012 11:13, schrieb Nguyễn Thái Ngọc Duy: Character class xdigit is the only one that hits 6 character limit defined by CHAR_CLASS_MAX_LENGTH. All other character classes are 5 character long and therefore never caught by this. This should make xdigit tests in t3070 pass on Windows.

Re: [PATCH 15/13] compat/fnmatch: fix off-by-one character class's length check

2012-11-13 Thread Johannes Sixt
Am 11.11.2012 11:13, schrieb Nguyễn Thái Ngọc Duy: - if (c1 == CHAR_CLASS_MAX_LENGTH) + if (c1 CHAR_CLASS_MAX_LENGTH) Nice catch! With this one and 14/13, all tests in t3070 pass on Windows. -- Hannes -- To unsubscribe from this list: send the line

[PATCH 15/13] compat/fnmatch: fix off-by-one character class's length check

2012-11-11 Thread Nguyễn Thái Ngọc Duy
Character class xdigit is the only one that hits 6 character limit defined by CHAR_CLASS_MAX_LENGTH. All other character classes are 5 character long and therefore never caught by this. This should make xdigit tests in t3070 pass on Windows. Reported-by: Johannes Sixt j...@kdbg.org