Re: [PATCH 15/19] reset.c: finish entire cmd_reset() whether or not pathspec is given

2013-01-09 Thread Junio C Hamano
Martin von Zweigbergk writes: > By not returning from inside the "if (pathspec)" block, we can let the > pathspec-aware and pathspec-less code share a bit more, making it > easier to make future changes that should affect both cases. This also > highlights the similarity between read_from_tree()

[PATCH 15/19] reset.c: finish entire cmd_reset() whether or not pathspec is given

2013-01-09 Thread Martin von Zweigbergk
By not returning from inside the "if (pathspec)" block, we can let the pathspec-aware and pathspec-less code share a bit more, making it easier to make future changes that should affect both cases. This also highlights the similarity between read_from_tree() and reset_index(). --- Should error repo