Re: [PATCH 15/19] tree-diff: no need to call "full" diff_tree_sha1 from show_path()

On Mon, Feb 24, 2014 at 08:21:47PM +0400, Kirill Smelkov wrote: > As described in previous commit, when recursing into sub-trees, we can > use lower-level tree walker, since its interface is now sha1 based. > > The change is ok, because diff_tree_sha1() only invokes > __diff_tree_sha1(), and also,

[PATCH 15/19] tree-diff: no need to call "full" diff_tree_sha1 from show_path()

As described in previous commit, when recursing into sub-trees, we can use lower-level tree walker, since its interface is now sha1 based. The change is ok, because diff_tree_sha1() only invokes __diff_tree_sha1(), and also, if base is empty, try_to_follow_renames(). But base is not empty here, as