Re: [PATCH 16/18] entry.c: update submodules when interesting

2017-03-07 Thread Junio C Hamano
Stefan Beller writes: >> In addition to mkdir(), would we also need the .git file that point >> into superproject's .git/modules/ too? > > The move_head function takes care of it > Both creation as well as deletion are handled in the move_head function, > when either new or old is NULL. Oh, if i

Re: [PATCH 16/18] entry.c: update submodules when interesting

2017-03-07 Thread Stefan Beller
On Tue, Mar 7, 2017 at 3:04 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >>> +if (!is_submodule_populated_gently(ce->name, &err)) { >>> +struct stat sb; >>> +if (lstat(ce->name, &sb)) >>> +

Re: [PATCH 16/18] entry.c: update submodules when interesting

2017-03-07 Thread Junio C Hamano
Junio C Hamano writes: >> +if (!is_submodule_populated_gently(ce->name, &err)) { >> +struct stat sb; >> +if (lstat(ce->name, &sb)) >> +die(_("could not stat file '%s'"), >> ce->name);

Re: [PATCH 16/18] entry.c: update submodules when interesting

2017-03-07 Thread Junio C Hamano
Stefan Beller writes: > Signed-off-by: Stefan Beller > --- > entry.c | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/entry.c b/entry.c > index c6eea240b6..d2b512da90 100644 > --- a/entry.c > +++ b/entry.c > @@ -2,6 +2,7 @@ > #include "blob.h" > #includ

[PATCH 16/18] entry.c: update submodules when interesting

2017-03-06 Thread Stefan Beller
Signed-off-by: Stefan Beller --- entry.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/entry.c b/entry.c index c6eea240b6..d2b512da90 100644 --- a/entry.c +++ b/entry.c @@ -2,6 +2,7 @@ #include "blob.h" #include "dir.h" #include "streaming.h" +#include "su

[PATCH 16/18] entry.c: update submodules when interesting

2017-03-01 Thread Stefan Beller
Signed-off-by: Stefan Beller --- entry.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/entry.c b/entry.c index c6eea240b6..d2b512da90 100644 --- a/entry.c +++ b/entry.c @@ -2,6 +2,7 @@ #include "blob.h" #include "dir.h" #include "streaming.h" +#include "su