On Thu, Aug 2, 2018 at 10:37 AM Eric Sunshine wrote:
>
> On Thu, Aug 2, 2018 at 7:46 AM Han-Wen Nienhuys wrote:
> > Sure. My doubt is that it's hard to tell what the state of my patch is
> > at any given time.
>
> Understandable. Junio sends out a periodic "What's cooking" email
> summarizing
On Thu, Aug 2, 2018 at 7:46 AM Han-Wen Nienhuys wrote:
> Sure. My doubt is that it's hard to tell what the state of my patch is
> at any given time.
Understandable. Junio sends out a periodic "What's cooking" email
summarizing the state of patches sent to the list. The most recent one
is here
On Thu, Aug 2, 2018 at 12:24 PM Eric Sunshine wrote:
>
> On Wed, Aug 1, 2018 at 2:17 PM Junio C Hamano wrote:
> > Han-Wen Nienhuys writes:
> > > Sorry for being dense, but do you want me to send an updated patch or
> > > not based on your and Eric's comments or not?
> >
> > It would help to see
On Tue, Jul 31, 2018 at 10:21 PM Eric Sunshine wrote:
>
> On Tue, Jul 31, 2018 at 1:37 PM Han-Wen Nienhuys wrote:
> > Highlight keywords in remote sideband output.
>
> Prefix with the module you're touching, don't capitalize, and drop the
> period. Perhaps:
Done.
> sideband: highlight
On Wed, Aug 1, 2018 at 2:17 PM Junio C Hamano wrote:
> Han-Wen Nienhuys writes:
> > Sorry for being dense, but do you want me to send an updated patch or
> > not based on your and Eric's comments or not?
>
> It would help to see the comments responded with either "such a
> change is not needed
On Wed, Aug 1, 2018 at 8:17 PM Junio C Hamano wrote:
> >> Hmm, do we actually say things like "Error: blah"? I am not sure if
> >> I like this strncasecmp all that much.
> >
> > this is for the remote end, so what we (git-core) says isn't all that
> > relevant.
>
> It is very relevant, I would
Han-Wen Nienhuys writes:
> On Wed, Aug 1, 2018 at 5:41 PM Junio C Hamano wrote:
>
>> Hmm, do we actually say things like "Error: blah"? I am not sure if
>> I like this strncasecmp all that much.
>
> this is for the remote end, so what we (git-core) says isn't all that
> relevant.
It is very
On Wed, Aug 1, 2018 at 5:41 PM Junio C Hamano wrote:
> Hmm, do we actually say things like "Error: blah"? I am not sure if
> I like this strncasecmp all that much.
this is for the remote end, so what we (git-core) says isn't all that
relevant. The reason I put this here is that Gerrit has some
Eric Sunshine writes:
> On Tue, Jul 31, 2018 at 1:37 PM Han-Wen Nienhuys wrote:
>> Highlight keywords in remote sideband output.
>
> Prefix with the module you're touching, don't capitalize, and drop the
> period. Perhaps:
>
> sideband: highlight keywords in remote sideband output
Yup (I
On Tue, Jul 31, 2018 at 1:37 PM Han-Wen Nienhuys wrote:
> Highlight keywords in remote sideband output.
Prefix with the module you're touching, don't capitalize, and drop the
period. Perhaps:
sideband: highlight keywords in remote sideband output
> The highlighting is done on the
Han-Wen Nienhuys writes:
> The highlighting is done on the client-side. Supported keywords are
> "error", "warning", "hint" and "success".
>
> The colorization is controlled with the config setting "color.remote".
>
> Co-authored-by: Duy Nguyen
> Signed-off-by: Han-Wen Nienhuys
Thanks. I'll
The highlighting is done on the client-side. Supported keywords are
"error", "warning", "hint" and "success".
The colorization is controlled with the config setting "color.remote".
Co-authored-by: Duy Nguyen
Signed-off-by: Han-Wen Nienhuys
---
Documentation/config.txt| 9 +++
The highlighting is done on the client-side. Supported keywords are
"error", "warning", "hint" and "success".
The colorization is controlled with the config setting "color.remote".
Signed-off-by: Han-Wen Nienhuys
---
sideband.c | 79 +
The highlighting is done on the client-side. Supported keywords are
"error", "warning", "hint" and "success".
The colorization is controlled with the config setting "color.remote".
Signed-off-by: Han-Wen Nienhuys
Change-Id: I090412a1288bc2caef0916447e28c2d0199da47d
---
sideband.c
14 matches
Mail list logo