Re: [PATCH 2/2] color: discourage use of ui.color=always

2017-10-12 Thread Junio C Hamano
Jeff King writes: > On Thu, Oct 12, 2017 at 11:10:07AM +0900, Junio C Hamano wrote: > >> Warn when we read such a configuration from a file, and nudge the >> users to spell them 'auto' instead. > > Hmm. On the one hand, it is nice to make people aware that their config > isn't

Re: [PATCH 2/2] color: discourage use of ui.color=always

2017-10-12 Thread Jeff King
On Thu, Oct 12, 2017 at 11:10:07AM +0900, Junio C Hamano wrote: > Warn when we read such a configuration from a file, and nudge the > users to spell them 'auto' instead. Hmm. On the one hand, it is nice to make people aware that their config isn't doing what they might think. On the other hand,

Re: [PATCH 2/2] color: discourage use of ui.color=always

2017-10-11 Thread Jonathan Nieder
Junio C Hamano wrote: > Warn when we read such a configuration from a file, and nudge the > users to spell them 'auto' instead. > > Signed-off-by: Junio C Hamano > --- > Documentation/config.txt | 2 +- > color.c | 7 +++ > 2 files changed, 8

[PATCH 2/2] color: discourage use of ui.color=always

2017-10-11 Thread Junio C Hamano
Warn when we read such a configuration from a file, and nudge the users to spell them 'auto' instead. Signed-off-by: Junio C Hamano --- Documentation/config.txt | 2 +- color.c | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git