Re: [PATCH 2/2] git_connect: factor out discovery of the protocol and its parts

2013-11-06 Thread Torsten Bögershausen
On 2013-11-05 22.22, Johannes Sixt wrote: > Am 05.11.2013 21:45, schrieb Torsten Bögershausen: >> On 2013-11-05 20.39, Johannes Sixt wrote: >> Thanks for picking this up, please see some minor nits inline, >> and git_connect() is at the end >> >>> -struct child_process *git_connect(int fd[2], const

Re: [PATCH 2/2] git_connect: factor out discovery of the protocol and its parts

2013-11-05 Thread Johannes Sixt
Am 05.11.2013 21:45, schrieb Torsten Bögershausen: > On 2013-11-05 20.39, Johannes Sixt wrote: > Thanks for picking this up, please see some minor nits inline, > and git_connect() is at the end > >> -struct child_process *git_connect(int fd[2], const char *url_orig, >> -

Re: [PATCH 2/2] git_connect: factor out discovery of the protocol and its parts

2013-11-05 Thread Torsten Bögershausen
On 2013-11-05 20.39, Johannes Sixt wrote: Thanks for picking this up, please see some minor nits inline, and git_connect() is at the end > -struct child_process *git_connect(int fd[2], const char *url_orig, > - const char *prog, int flags) > +static enum protocol pars

[PATCH 2/2] git_connect: factor out discovery of the protocol and its parts

2013-11-05 Thread Johannes Sixt
git_connect has grown large due to the many different protocols syntaxes that are supported. Move the part of the function that parses the URL to connect to into a separate function for readability. Signed-off-by: Johannes Sixt --- Apart from this "simplification", the protocol parsing code is a