Re: [PATCH 2/2] pickaxe: use textconv for -S counting

2012-11-19 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Tue, Nov 13, 2012 at 03:13:19PM -0800, Junio C Hamano wrote: static int has_changes(struct diff_filepair *p, struct diff_options *o, regex_t *regexp, kwset_t kws) { + struct userdiff_driver *textconv_one = get_textconv(p-one); +

Re: [PATCH 2/2] pickaxe: use textconv for -S counting

2012-11-14 Thread Jeff King
On Tue, Nov 13, 2012 at 03:13:19PM -0800, Junio C Hamano wrote: static int has_changes(struct diff_filepair *p, struct diff_options *o, regex_t *regexp, kwset_t kws) { + struct userdiff_driver *textconv_one = get_textconv(p-one); + struct userdiff_driver

Re: [PATCH 2/2] pickaxe: use textconv for -S counting

2012-11-13 Thread Junio C Hamano
Jeff King p...@peff.net writes: We currently just look at raw blob data when using -S to pickaxe. This is mostly historical, as pickaxe predates the textconv feature. If the user has bothered to define a textconv filter, it is more likely that their search string will be on the textconv

[PATCH 2/2] pickaxe: use textconv for -S counting

2012-10-28 Thread Jeff King
We currently just look at raw blob data when using -S to pickaxe. This is mostly historical, as pickaxe predates the textconv feature. If the user has bothered to define a textconv filter, it is more likely that their search string will be on the textconv output, as that is what they will see in