On Fri, Jul 20, 2018 at 02:30:23AM -0700, Junio C Hamano wrote:
> > The entries in shallow file says that history behind them may not
> > exist in the repository due to its shallowness but history after
> > them are supposed to be traversable (otherwise we have a repository
> > corruption). It
Junio C Hamano writes:
> Sorry, but I do not think I can relay that as an explanation why it
> won't cause problems to a third person.
OK, ignore this. I was being stupid.
> The entries in shallow file says that history behind them may not
> exist in the repository due to its shallowness but
Johannes Schindelin writes:
> On Tue, 17 Jul 2018, Junio C Hamano wrote:
>
>> Jeff King writes:
>>
>> > I'm OK with having a partial fix, or one that fixes immediate pain
>> > without doing a big cleanup, as long as it doesn't make anything _worse_
>> > in a user-visible way. And that's really
Hi,
On Tue, 17 Jul 2018, Duy Nguyen wrote:
> On Tue, Jul 17, 2018 at 6:39 PM Duy Nguyen wrote:
> >
> > On Fri, Jul 13, 2018 at 10:19 PM Johannes Schindelin via GitGitGadget
> > wrote:
> > >
> > > From: Johannes Schindelin
> > >
> > > While it is true that we never add unreachable commits into
Hi Junio,
On Tue, 17 Jul 2018, Junio C Hamano wrote:
> Jeff King writes:
>
> > I'm OK with having a partial fix, or one that fixes immediate pain
> > without doing a big cleanup, as long as it doesn't make anything _worse_
> > in a user-visible way. And that's really my question: is pruning
On Wed, Jul 18, 2018 at 7:45 PM Jeff King wrote:
>
> On Wed, Jul 18, 2018 at 07:31:40PM +0200, Duy Nguyen wrote:
>
> > > Sort of an aside to the patch under discussion, but I think it may make
> > > sense for prune_shallow() to take a callback function for determining
> > > whether a commit is
On Wed, Jul 18, 2018 at 07:31:40PM +0200, Duy Nguyen wrote:
> > Sort of an aside to the patch under discussion, but I think it may make
> > sense for prune_shallow() to take a callback function for determining
> > whether a commit is reachable.
> >
> > I have an old patch that teaches git-prune
On Tue, Jul 17, 2018 at 9:41 PM Jeff King wrote:
> I slept on this to see if I could brainstorm any other ways.
>
> ..
>
> Sort of an aside to the patch under discussion, but I think it may make
> sense for prune_shallow() to take a callback function for determining
> whether a commit is
On Tue, Jul 17, 2018 at 07:28:07PM +0200, Duy Nguyen wrote:
> On Mon, Jul 16, 2018 at 7:38 PM Jeff King wrote:
> > in a user-visible way. And that's really my question: is pruning here
> > going to bite people unexpectedly (not rhetorical -- I really don't
> > know)?
>
> If shallow points are
On Mon, Jul 16, 2018 at 7:38 PM Jeff King wrote:
> in a user-visible way. And that's really my question: is pruning here
> going to bite people unexpectedly (not rhetorical -- I really don't
> know)?
If shallow points are no longer reachable, removing them should not
bite anybody, I think.
>
On Tue, Jul 17, 2018 at 6:39 PM Duy Nguyen wrote:
>
> On Fri, Jul 13, 2018 at 10:19 PM Johannes Schindelin via GitGitGadget
> wrote:
> >
> > From: Johannes Schindelin
> >
> > While it is true that we never add unreachable commits into pack files
> > intentionally (as `git repack`'s
On Fri, Jul 13, 2018 at 10:19 PM Johannes Schindelin via GitGitGadget
wrote:
>
> From: Johannes Schindelin
>
> While it is true that we never add unreachable commits into pack files
> intentionally (as `git repack`'s documentation states), we must not
> forget that a `git fetch --prune` (or even
Jeff King writes:
> I'm OK with having a partial fix, or one that fixes immediate pain
> without doing a big cleanup, as long as it doesn't make anything _worse_
> in a user-visible way. And that's really my question: is pruning here
> going to bite people unexpectedly (not rhetorical -- I
On Sat, Jul 14, 2018 at 11:56:57PM +0200, Johannes Schindelin wrote:
> > > To avoid this problem, let's prune the shallow list in `git repack` when
> > > the `-d` option is passed, unless `-A` is passed, too (which would force
> > > the now-unreachable objects to be turned into loose objects
Hi Peff,
On Fri, 13 Jul 2018, Jeff King wrote:
> On Thu, Jul 12, 2018 at 12:23:28AM +0200, Johannes Schindelin via
> GitGitGadget wrote:
>
> > This is particularly important to keep in mind when looking at the
> > `.git/shallow` file: if any commits listed in that file become
> > unreachable,
On Thu, Jul 12, 2018 at 12:23:28AM +0200, Johannes Schindelin via GitGitGadget
wrote:
> This is particularly important to keep in mind when looking at the
> `.git/shallow` file: if any commits listed in that file become
> unreachable, it is not a problem, but if they go missing, it *is* a
>
From: Johannes Schindelin
While it is true that we never add unreachable commits into pack files
intentionally (as `git repack`'s documentation states), we must not
forget that a `git fetch --prune` (or even a `git fetch` when a ref was
force-pushed in the meantime) can make a commit unreachable
17 matches
Mail list logo
