Re: [PATCH 2/2] submodule: Add --dissociate option to add/update commands

2018-05-01 Thread Casey Fitzpatrick
Thanks, I will clean up the braces and commit message. I have to disagree with the 's/reference/dissociate/' comments. It appears this section of option descriptions mostly copies from the descriptions given by 'git clone -h', which outputs: --reference reference repository

Re: [PATCH 2/2] submodule: Add --dissociate option to add/update commands

2018-05-01 Thread Eric Sunshine
On Tue, May 1, 2018 at 2:09 PM, Casey Fitzpatrick wrote: > submodule: Add --dissociate option to add/update commands s/Add/add/ > Add --dissociate option to add and update commands, both clone helper commands > that already have the --reference option --dissociate pairs with.

Re: [PATCH 2/2] submodule: Add --dissociate option to add/update commands

2018-05-01 Thread Stefan Beller
On Tue, May 1, 2018 at 11:09 AM, Casey Fitzpatrick wrote: > > +test_expect_success 'submodule add --reference with --dissociate doesnt use > alternates' ' > + ( > + cd super && > + git submodule add --reference ../B --dissociate >

[PATCH 2/2] submodule: Add --dissociate option to add/update commands

2018-05-01 Thread Casey Fitzpatrick
Add --dissociate option to add and update commands, both clone helper commands that already have the --reference option --dissociate pairs with. Add documentation. Add tests. Signed-off-by: Casey Fitzpatrick --- Documentation/git-submodule.txt | 10 +-