Re: [PATCH 2/2] submodule: Try harder to fetch needed sha1 by direct fetching sha1

2016-02-22 Thread Junio C Hamano
Stefan Beller writes: > On Mon, Feb 22, 2016 at 4:01 PM, Junio C Hamano wrote: >> >> Stefan Beller writes: >> >> > We may want to discuss the error message. It is the same as in the case >> > before (git-fetch ), this is good for translation, but may be bad >> > for the user as we may want to g

Re: [PATCH 2/2] submodule: Try harder to fetch needed sha1 by direct fetching sha1

2016-02-22 Thread Stefan Beller
On Mon, Feb 22, 2016 at 4:01 PM, Junio C Hamano wrote: > > Stefan Beller writes: > > > We may want to discuss the error message. It is the same as in the case > > before (git-fetch ), this is good for translation, but may be bad > > for the user as we may want to give extra information. > > ("We

Re: [PATCH 2/2] submodule: Try harder to fetch needed sha1 by direct fetching sha1

2016-02-22 Thread Junio C Hamano
Stefan Beller writes: > We may want to discuss the error message. It is the same as in the case > before (git-fetch ), this is good for translation, but may be bad > for the user as we may want to give extra information. > ("We fetched for you and it worked, however the sha1 was not included, > s

[PATCH 2/2] submodule: Try harder to fetch needed sha1 by direct fetching sha1

2016-02-22 Thread Stefan Beller
When reviewing a change in Gerrit, which also updates a submodule, a common review practice is to download and cherry-pick the patch locally to test it. However when testing it locally, the 'git submodule update' may fail fetching the correct submodule sha1 as the corresponding commit in the submod