Re: [PATCH 2/2] submodule: don't print status output with ignore=all

2013-08-17 Thread brian m. carlson
On Sun, Aug 11, 2013 at 04:03:17PM +, brian m. carlson wrote: On Sat, Aug 03, 2013 at 11:24:20AM -0700, Jonathan Nieder wrote: If I just renamed a submodule, will 'module_name $path' do the right thing with the old path? module_name uses whatever's in .gitmodules. I'm not sure what

Re: [PATCH 2/2] submodule: don't print status output with ignore=all

2013-08-11 Thread brian m. carlson
On Sat, Aug 03, 2013 at 11:24:20AM -0700, Jonathan Nieder wrote: If I have '[submodule favorite] ignore = all' and I then replace that submodule with a blob, should git submodule status not mention that path? Yes, I think it should. I'll fix this in the reroll. If I just renamed a

Re: [PATCH 2/2] submodule: don't print status output with ignore=all

2013-08-11 Thread Jonathan Nieder
brian m. carlson wrote: module_name uses whatever's in .gitmodules. I'm not sure what you mean by renamed a submodule, since git mv foo bar fails with: vauxhall ok % git mv .vim/bundle/ctrlp .vim/bundle/ctrlq fatal: source directory is empty, source=.vim/bundle/ctrlp,

Re: [PATCH 2/2] submodule: don't print status output with ignore=all

2013-08-10 Thread brian m. carlson
On Sun, Aug 04, 2013 at 08:24:09PM +0200, Jens Lehmann wrote: I'm a bit confused. The commit message talks about git status, but the code you changed handles git submodule summary. Looks like you are trying to fix the output of status when the status.submodulesummary option is set, right?

Re: [PATCH 2/2] submodule: don't print status output with ignore=all

2013-08-04 Thread Jens Lehmann
Am 03.08.2013 20:24, schrieb Jonathan Nieder: brian m. carlson wrote: git status prints information for submodules, but it should ignore the status of those which have submodule.name.ignore set to all. Fix it so that it does properly ignore those which have that setting either in

[PATCH 2/2] submodule: don't print status output with ignore=all

2013-08-03 Thread brian m. carlson
git status prints information for submodules, but it should ignore the status of those which have submodule.name.ignore set to all. Fix it so that it does properly ignore those which have that setting either in .git/config or in .gitmodules. Signed-off-by: brian m. carlson

Re: [PATCH 2/2] submodule: don't print status output with ignore=all

2013-08-03 Thread Jonathan Nieder
brian m. carlson wrote: git status prints information for submodules, but it should ignore the status of those which have submodule.name.ignore set to all. Fix it so that it does properly ignore those which have that setting either in .git/config or in .gitmodules. Signed-off-by: brian