[PATCH 2/2] t7700: do not use touch -r

2014-01-23 Thread Jeff King
Some versions of touch (such as /usr/ucb/touch on Solaris) do not know about the -r option. This would make sense as a feature of test-chmtime, but fortunately this fix is even easier. The test does not care about the timestamp of the .keep file it creates at all, only that it exists. So we can

Re: [PATCH 2/2] t7700: do not use touch -r

2014-01-23 Thread Junio C Hamano
Jeff King p...@peff.net writes: ... The test does not care about the timestamp of the .keep file it creates at all, only that it exists. Please refrain from using touch for such use cases in the first place. It appears that pack-$packsha1.keep is what the test wants. -- To

Re: [PATCH 2/2] t7700: do not use touch -r

2014-01-23 Thread Jeff King
On Thu, Jan 23, 2014 at 01:12:55PM -0800, Junio C Hamano wrote: Jeff King p...@peff.net writes: ... The test does not care about the timestamp of the .keep file it creates at all, only that it exists. Please refrain from using touch for such use cases in the first place. It appears

Re: [PATCH 2/2] t7700: do not use touch -r

2014-01-23 Thread Junio C Hamano
Jeff King p...@peff.net writes: Agreed. I was making the minimal change, but I think there is no reason not to fix both while we are there. Do you want to just mark up the patch in transit? Let's just queue this instead. -- 8 -- From: Jeff King p...@peff.net Date: Thu, 23 Jan 2014 14:55:18

Re: [PATCH 2/2] t7700: do not use touch -r

2014-01-23 Thread Jeff King
On Thu, Jan 23, 2014 at 01:24:44PM -0800, Junio C Hamano wrote: Jeff King p...@peff.net writes: Agreed. I was making the minimal change, but I think there is no reason not to fix both while we are there. Do you want to just mark up the patch in transit? Let's just queue this instead.