Re: [PATCH 2/2] t9200: avoid grep on non-ASCII data

2016-02-23 Thread Junio C Hamano
Jeff King writes: > On Sun, Feb 21, 2016 at 11:43:45PM +, John Keeping wrote: > >> On Sun, Feb 21, 2016 at 04:15:31PM -0500, Eric Sunshine wrote: >> > On Sun, Feb 21, 2016 at 12:32 PM, John Keeping wrote: >> > > GNU grep 2.23 detects the input used in this test as binary data so it >> > > do

Re: [PATCH 2/2] t9200: avoid grep on non-ASCII data

2016-02-22 Thread Jeff King
On Sun, Feb 21, 2016 at 11:43:45PM +, John Keeping wrote: > On Sun, Feb 21, 2016 at 04:15:31PM -0500, Eric Sunshine wrote: > > On Sun, Feb 21, 2016 at 12:32 PM, John Keeping wrote: > > > GNU grep 2.23 detects the input used in this test as binary data so it > > > does not work for extracting

Re: [PATCH 2/2] t9200: avoid grep on non-ASCII data

2016-02-21 Thread Eric Sunshine
On Sun, Feb 21, 2016 at 6:43 PM, John Keeping wrote: > On Sun, Feb 21, 2016 at 04:15:31PM -0500, Eric Sunshine wrote: >> On Sun, Feb 21, 2016 at 12:32 PM, John Keeping wrote: >> > GNU grep 2.23 detects the input used in this test as binary data so it >> > does not work for extracting lines from a

Re: [PATCH 2/2] t9200: avoid grep on non-ASCII data

2016-02-21 Thread John Keeping
On Sun, Feb 21, 2016 at 04:15:31PM -0500, Eric Sunshine wrote: > On Sun, Feb 21, 2016 at 12:32 PM, John Keeping wrote: > > GNU grep 2.23 detects the input used in this test as binary data so it > > does not work for extracting lines from a file. We could add the "-a" > > option to force grep to t

Re: [PATCH 2/2] t9200: avoid grep on non-ASCII data

2016-02-21 Thread Eric Sunshine
On Sun, Feb 21, 2016 at 12:32 PM, John Keeping wrote: > GNU grep 2.23 detects the input used in this test as binary data so it > does not work for extracting lines from a file. We could add the "-a" > option to force grep to treat the input as text, but not all > implementations support that. In

[PATCH 2/2] t9200: avoid grep on non-ASCII data

2016-02-21 Thread John Keeping
GNU grep 2.23 detects the input used in this test as binary data so it does not work for extracting lines from a file. We could add the "-a" option to force grep to treat the input as text, but not all implementations support that. Instead, use sed to extract the desired lines since it will alway