Re: [PATCH 2/2] transport-helper: update remote helper namespace

2013-04-15 Thread Jonathan Nieder
Junio C Hamano wrote: Just rerolling with what _you_ think is an appropriate level of explanation (either or both in log and in-code) and see what happens would probably be the best way to proceed, I think, at this point. Either you hear It still is wrong and too sketchy, Yeah, thinking

Re: [PATCH 2/2] transport-helper: update remote helper namespace

2013-04-14 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: Why wasn't this patch merged to 'pu'? To my knowledge nobody raised any real concerns. There are many reasons not to queue _everything_ ever posted to the list on 'pu', and they are almost always not a deliberate rejection. The maintainer

Re: [PATCH 2/2] transport-helper: update remote helper namespace

2013-04-14 Thread Felipe Contreras
On Sun, Apr 14, 2013 at 12:13 AM, Junio C Hamano gits...@pobox.com wrote: Felipe Contreras felipe.contre...@gmail.com writes: Why wasn't this patch merged to 'pu'? To my knowledge nobody raised any real concerns. There are many reasons not to queue _everything_ ever posted to the list on

Re: [PATCH 2/2] transport-helper: update remote helper namespace

2013-04-14 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: On Sun, Apr 14, 2013 at 12:13 AM, Junio C Hamano gits...@pobox.com wrote: Felipe Contreras felipe.contre...@gmail.com writes: Why wasn't this patch merged to 'pu'? To my knowledge nobody raised any real concerns. There are many reasons

Re: [PATCH 2/2] transport-helper: update remote helper namespace

2013-04-14 Thread Jeff King
On Sun, Apr 14, 2013 at 11:45:10AM -0700, Junio C Hamano wrote: Just rerolling with what _you_ think is an appropriate level of explanation (either or both in log and in-code) and see what happens would probably be the best way to proceed, I think, at this point. Either you hear It still is

Re: [PATCH 2/2] transport-helper: update remote helper namespace

2013-04-13 Thread Felipe Contreras
Hi, Why wasn't this patch merged to 'pu'? To my knowledge nobody raised any real concerns. Should I explain in every commit that touches transport-helper how remote-helpers without marks are impossible? I know I said I was going to update the commit message, but I don't think that reason to not

[PATCH 2/2] transport-helper: update remote helper namespace

2013-04-10 Thread Felipe Contreras
When pushing, the remote namespace is updated correctly (e.g. refs/origin/master), but not the remote helper's (e.g. refs/testgit/origin/master). Let's update it correctly. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- t/t5801-remote-helpers.sh | 12

Re: [PATCH 2/2] transport-helper: update remote helper namespace

2013-04-10 Thread Jeff King
On Wed, Apr 10, 2013 at 07:07:12PM -0500, Felipe Contreras wrote: When pushing, the remote namespace is updated correctly (e.g. refs/origin/master), but not the remote helper's (e.g. refs/testgit/origin/master). Let's update it correctly. I would have thought it was the helper's

Re: [PATCH 2/2] transport-helper: update remote helper namespace

2013-04-10 Thread Felipe Contreras
On Wed, Apr 10, 2013 at 11:33 PM, Jeff King p...@peff.net wrote: On Wed, Apr 10, 2013 at 07:07:12PM -0500, Felipe Contreras wrote: When pushing, the remote namespace is updated correctly (e.g. refs/origin/master), but not the remote helper's (e.g. refs/testgit/origin/master). Let's update

Re: [PATCH 2/2] transport-helper: update remote helper namespace

2013-04-10 Thread Jeff King
On Wed, Apr 10, 2013 at 11:53:38PM -0500, Felipe Contreras wrote: But if we push some commits to the helper, moving Y up to Z, then it would build the new commit (which contains the foreign-vcs's equivalent of Y..Z) on top of Z, not Y. Why would it do that? If X points to say revision

Re: [PATCH 2/2] transport-helper: update remote helper namespace

2013-04-10 Thread Felipe Contreras
On Thu, Apr 11, 2013 at 12:05 AM, Jeff King p...@peff.net wrote: On Wed, Apr 10, 2013 at 11:53:38PM -0500, Felipe Contreras wrote: But if we push some commits to the helper, moving Y up to Z, then it would build the new commit (which contains the foreign-vcs's equivalent of Y..Z) on top of