Re: [PATCH 2/2] travis-ci: fail if Coccinelle static analysis found something to transform

2018-07-26 Thread Junio C Hamano
SZEDER Gábor writes: > On Mon, Jul 23, 2018 at 3:02 PM SZEDER Gábor wrote: > >> The only way to draw attention in such an automated setting is to fail >> the build job. Therefore, modify the 'ci/run-static-analysis.sh' >> build script to check all the resulting '*.cocci.patch' files, and >>

Re: [PATCH 2/2] travis-ci: fail if Coccinelle static analysis found something to transform

2018-07-26 Thread SZEDER Gábor
On Mon, Jul 23, 2018 at 3:02 PM SZEDER Gábor wrote: > The only way to draw attention in such an automated setting is to fail > the build job. Therefore, modify the 'ci/run-static-analysis.sh' > build script to check all the resulting '*.cocci.patch' files, and > fail the build job if any of

Re: [PATCH 2/2] travis-ci: fail if Coccinelle static analysis found something to transform

2018-07-23 Thread Derrick Stolee
On 7/23/2018 9:02 AM, SZEDER Gábor wrote: Coccinelle's and in turn 'make coccicheck's exit code only indicates that Coccinelle managed to finish its analysis without any errors (e.g. no unknown --options, no missing files, no syntax errors in the semantic patches, etc.), but it doesn't indicate

[PATCH 2/2] travis-ci: fail if Coccinelle static analysis found something to transform

2018-07-23 Thread SZEDER Gábor
Coccinelle's and in turn 'make coccicheck's exit code only indicates that Coccinelle managed to finish its analysis without any errors (e.g. no unknown --options, no missing files, no syntax errors in the semantic patches, etc.), but it doesn't indicate whether it found any undesired code patterns