Re: [PATCH 2/2 v4] tag: support configuring --sort via .gitconfig

2014-07-11 Thread Junio C Hamano
Jacob Keller jacob.e.kel...@intel.com writes: Add support for configuring default sort ordering for git tags. Command line option will override this configured value, using the exact same syntax. Cc: Jeff King p...@peff.net Signed-off-by: Jacob Keller jacob.e.kel...@intel.com --- - v4 *

Re: [PATCH 2/2 v4] tag: support configuring --sort via .gitconfig

2014-07-11 Thread Keller, Jacob E
On Fri, 2014-07-11 at 08:04 -0700, Junio C Hamano wrote: Jacob Keller jacob.e.kel...@intel.com writes: Add support for configuring default sort ordering for git tags. Command line option will override this configured value, using the exact same syntax. Cc: Jeff King p...@peff.net

Re: [PATCH 2/2 v4] tag: support configuring --sort via .gitconfig

2014-07-11 Thread Junio C Hamano
Keller, Jacob E jacob.e.kel...@intel.com writes: On Fri, 2014-07-11 at 08:04 -0700, Junio C Hamano wrote: ... +static int tag_sort = 0; Please do not initialize variables in bss segment to 0 by hand. If this variable is meant to take one of these *CMP_SORT values defined as macro later

Re: [PATCH 2/2 v4] tag: support configuring --sort via .gitconfig

2014-07-11 Thread Keller, Jacob E
On Fri, 2014-07-11 at 08:04 -0700, Junio C Hamano wrote: Jacob Keller jacob.e.kel...@intel.com writes: Add support for configuring default sort ordering for git tags. Command line option will override this configured value, using the exact same syntax. Cc: Jeff King p...@peff.net

Re: [PATCH 2/2 v4] tag: support configuring --sort via .gitconfig

2014-07-11 Thread Junio C Hamano
Keller, Jacob E jacob.e.kel...@intel.com writes: This is not how the rest of the current tests work. I will submit a patch which fixes up the current --sort tests (but not every test, for now) as well. I do not want to pile more work that is unrelated to the task at hand on your plate, i.e.

Re: [PATCH 2/2 v4] tag: support configuring --sort via .gitconfig

2014-07-11 Thread Keller, Jacob E
On Fri, 2014-07-11 at 11:29 -0700, Junio C Hamano wrote: Keller, Jacob E jacob.e.kel...@intel.com writes: This is not how the rest of the current tests work. I will submit a patch which fixes up the current --sort tests (but not every test, for now) as well. I do not want to pile more

[PATCH 2/2 v4] tag: support configuring --sort via .gitconfig

2014-07-10 Thread Jacob Keller
Add support for configuring default sort ordering for git tags. Command line option will override this configured value, using the exact same syntax. Cc: Jeff King p...@peff.net Signed-off-by: Jacob Keller jacob.e.kel...@intel.com --- - v4 * base on top of suggested change by Jeff King to use