Re: [PATCH 2/3] Allow Git::get_tz_offset to properly handle DST boundary times

2013-01-20 Thread Junio C Hamano
Ben Walton writes: > also avoids the oddball 1/2 hour DST shift. I can re-roll the series > with your code (and credit for it) or you can apply you change on top > of my series...whichever is easiest for you. Please reroll, as I do not have patience either to set up a test case and verify the e

Re: [PATCH 2/3] Allow Git::get_tz_offset to properly handle DST boundary times

2013-01-20 Thread Ben Walton
On Thu, Jan 17, 2013 at 7:09 PM, Junio C Hamano wrote: > Ben Walton writes: > >> The Git::get_tz_offset is meant to provide a workalike replacement for >> the GNU strftime %z format specifier. The algorithm used failed to >> properly handle DST boundary cases. >> >> For example, the unix time 11

Re: [PATCH 2/3] Allow Git::get_tz_offset to properly handle DST boundary times

2013-01-17 Thread Junio C Hamano
Ben Walton writes: > The Git::get_tz_offset is meant to provide a workalike replacement for > the GNU strftime %z format specifier. The algorithm used failed to > properly handle DST boundary cases. > > For example, the unix time 1162105199 in CST6CDT saw set_tz_offset > improperly return -0600

[PATCH 2/3] Allow Git::get_tz_offset to properly handle DST boundary times

2013-01-15 Thread Ben Walton
The Git::get_tz_offset is meant to provide a workalike replacement for the GNU strftime %z format specifier. The algorithm used failed to properly handle DST boundary cases. For example, the unix time 1162105199 in CST6CDT saw set_tz_offset improperly return -0600 instead of -0500. TZ=CST6CDT da