Re: [PATCH 2/3] difftool: avoid $GIT_DIR and $GIT_WORK_TREE

On Tue, Jul 19, 2016 at 02:06:35PM -0700, Junio C Hamano wrote: > Junio C Hamano writes: > > > It is not wrong per-se, but as you are in a subshell, you do not > > have to unset these, I would think. Not worth a reroll, but unless > > I am overlooking something (in which case

Re: [PATCH 2/3] difftool: avoid $GIT_DIR and $GIT_WORK_TREE

Junio C Hamano writes: > It is not wrong per-se, but as you are in a subshell, you do not > have to unset these, I would think. Not worth a reroll, but unless > I am overlooking something (in which case please holler) I'm > inclined to remove these two lines myself while

Re: [PATCH 2/3] difftool: avoid $GIT_DIR and $GIT_WORK_TREE

David Aguilar writes: > Environment variables are global and hard to reason about. > Use the `--git-dir` and `--work-tree` arguments when invoking `git` > instead of relying on the environment. > > Add a test to ensure that difftool's dir-diff feature works when these >

[PATCH 2/3] difftool: avoid $GIT_DIR and $GIT_WORK_TREE

Environment variables are global and hard to reason about. Use the `--git-dir` and `--work-tree` arguments when invoking `git` instead of relying on the environment. Add a test to ensure that difftool's dir-diff feature works when these variables are present in the environment. Signed-off-by: