Re: [PATCH 2/3] for-each-ref: let upstream/push optionally report merge name.

2017-10-05 Thread Junio C Hamano
Junio C Hamano writes: > I think the remaining points from my reviews are: > > - It would be better to compute precomputable stuff when used atoms >are parsed, instead of running starts_with() in these functions; After reading the original (before these three patches)

Re: [PATCH 2/3] for-each-ref: let upstream/push optionally report merge name.

2017-10-04 Thread Junio C Hamano
Junio C Hamano writes: >> +if (explicit) >> +*s = xstrdup(merge); >> +else >> +*s = ""; > > Here is the same "who are we trying to help---users who want to know > where their push goes, or users who are debugging

Re: [PATCH 2/3] for-each-ref: let upstream/push optionally report merge name.

2017-10-04 Thread Junio C Hamano
Johannes Schindelin writes: > From: J Wyman > > There are times when scripts want to know not only the name of the > push branch on the remote, but also the name of the branch as known > by the remote repository. > > A useful example of this is

[PATCH 2/3] for-each-ref: let upstream/push optionally report merge name.

2017-10-02 Thread Johannes Schindelin
From: J Wyman There are times when scripts want to know not only the name of the push branch on the remote, but also the name of the branch as known by the remote repository. A useful example of this is with the push command where `branch..merge` is useful as the value.