Re: [RFC] deprecate git stash save? (was: Re: [PATCH 2/3] http-push: fix construction of hex value from path)

2017-10-17 Thread Thomas Gummerer
On 10/17, Jeff King wrote: > On Thu, Oct 05, 2017 at 09:00:49PM +0100, Thomas Gummerer wrote: > > > Since you were asking :) With the introduction of 'git stash push', > > my hope was always that we could eventually get rid of 'git stash > > save' and only keep one interface around. > > > > As

Re: [RFC] deprecate git stash save? (was: Re: [PATCH 2/3] http-push: fix construction of hex value from path)

2017-10-16 Thread Jeff King
On Thu, Oct 05, 2017 at 09:00:49PM +0100, Thomas Gummerer wrote: > Since you were asking :) With the introduction of 'git stash push', > my hope was always that we could eventually get rid of 'git stash > save' and only keep one interface around. > > As there still many references to it around

[RFC] deprecate git stash save? (was: Re: [PATCH 2/3] http-push: fix construction of hex value from path)

2017-10-05 Thread Thomas Gummerer
On 10/04, Junio C Hamano wrote: > I do not object with such a well designed deprecation plan for any > other features, if there are other "favourite" ones people would > want to deprecate and eventually remove, by the way. Since you were asking :) With the introduction of 'git stash push', my

Re: [PATCH 2/3] http-push: fix construction of hex value from path

2017-10-04 Thread Junio C Hamano
Jeff King writes: > More seriously, is there any interest in marking it as deprecated in the > release notes and issuing a warning when it's used for a few cycles? No objection from me. I do not object with such a well designed deprecation plan for any other features, if there

Re: [PATCH 2/3] http-push: fix construction of hex value from path

2017-10-03 Thread Jeff King
On Wed, Oct 04, 2017 at 02:20:05PM +0900, Junio C Hamano wrote: > Junio C Hamano writes: > > > Jeff King writes: > > > >>> Moreover, this is in the webdav-based "dumb http" push code path, > >>> which I do not trust much at all. I wonder if we could retire it

Re: [PATCH 2/3] http-push: fix construction of hex value from path

2017-10-03 Thread Junio C Hamano
Junio C Hamano writes: > Jeff King writes: > >>> Moreover, this is in the webdav-based "dumb http" push code path, >>> which I do not trust much at all. I wonder if we could retire it >>> completely (or at least provide an option to turn it off). >> >> I would

Re: [PATCH 2/3] http-push: fix construction of hex value from path

2017-10-03 Thread Junio C Hamano
Jeff King writes: >> Moreover, this is in the webdav-based "dumb http" push code path, >> which I do not trust much at all. I wonder if we could retire it >> completely (or at least provide an option to turn it off). > > I would really like that, too. It has been the cause of a

Re: [PATCH 2/3] http-push: fix construction of hex value from path

2017-10-03 Thread Jeff King
On Tue, Oct 03, 2017 at 03:53:15PM -0700, Jonathan Nieder wrote: > Thomas Gummerer wrote: > > > The get_oid_hex_from_objpath takes care of creating a oid from a > > pathname. It does this by memcpy'ing the first two bytes of the path to > > the "hex" string, then skipping the '/', and then

Re: [PATCH 2/3] http-push: fix construction of hex value from path

2017-10-03 Thread Jonathan Nieder
Hi, Thomas Gummerer wrote: > The get_oid_hex_from_objpath takes care of creating a oid from a > pathname. It does this by memcpy'ing the first two bytes of the path to > the "hex" string, then skipping the '/', and then copying the rest of the > path to the "hex" string. Currently it fails to

[PATCH 2/3] http-push: fix construction of hex value from path

2017-10-03 Thread Thomas Gummerer
The get_oid_hex_from_objpath takes care of creating a oid from a pathname. It does this by memcpy'ing the first two bytes of the path to the "hex" string, then skipping the '/', and then copying the rest of the path to the "hex" string. Currently it fails to increase the pointer to the hex