Re: [PATCH 2/3] perf/aggregate: add --reponame option

2018-01-28 Thread Christian Couder
On Sun, Jan 28, 2018 at 8:57 PM, Eric Sunshine wrote: > > Not a big deal, but the extra indentation (and noisy diff) could be > avoided like this: > > my $environment; > if ($reponame) { > $environment = $reponame; > } else if (exists ...) { > ...as before > }

Re: [PATCH 2/3] perf/aggregate: add --reponame option

2018-01-28 Thread Eric Sunshine
On Sun, Jan 28, 2018 at 6:18 AM, Christian Couder wrote: > This makes it easier to use the aggregate script > on the command line when one wants to get the > "environment" fields set in the codespeed output. > > Previously setting GIT_REPO_NAME was needed > for this purpose. > > Signed-off-by: Chr

[PATCH 2/3] perf/aggregate: add --reponame option

2018-01-28 Thread Christian Couder
This makes it easier to use the aggregate script on the command line when one wants to get the "environment" fields set in the codespeed output. Previously setting GIT_REPO_NAME was needed for this purpose. Signed-off-by: Christian Couder --- t/perf/aggregate.perl | 31 +