[PATCH 0/2] Cleanup refs API [WAS: Re: [PATCH 2/3] refs: introduce new API, wrap old API shallowly around new API]

2018-07-30 Thread Stefan Beller
> > I anticipate that we need to have a lot of back pointers to the repository > > in question, hence I think we should have the repository pointer promoted > > to not just a back pointer. > > I will probably need more time to study that commit and maybe the mail > archive for the history of this

Re: [PATCH 2/3] refs: introduce new API, wrap old API shallowly around new API

2018-07-27 Thread Duy Nguyen
On Fri, Jul 27, 2018 at 7:31 PM Stefan Beller wrote: > > On Fri, Jul 27, 2018 at 10:19 AM Brandon Williams wrote: > > > > On 07/27, Duy Nguyen wrote: > > > On Fri, Jul 27, 2018 at 2:40 AM Stefan Beller wrote: > > > > > > > > Currently the refs API takes a 'ref_store' as an argument to specify >

Re: [PATCH 2/3] refs: introduce new API, wrap old API shallowly around new API

2018-07-27 Thread Stefan Beller
On Fri, Jul 27, 2018 at 10:19 AM Brandon Williams wrote: > > On 07/27, Duy Nguyen wrote: > > On Fri, Jul 27, 2018 at 2:40 AM Stefan Beller wrote: > > > > > > Currently the refs API takes a 'ref_store' as an argument to specify > > > which ref store to iterate over; however it is more useful to

Re: [PATCH 2/3] refs: introduce new API, wrap old API shallowly around new API

2018-07-27 Thread Brandon Williams
On 07/27, Duy Nguyen wrote: > On Fri, Jul 27, 2018 at 2:40 AM Stefan Beller wrote: > > > > Currently the refs API takes a 'ref_store' as an argument to specify > > which ref store to iterate over; however it is more useful to specify > > the repository instead (or later a specific worktree of a

Re: [PATCH 2/3] refs: introduce new API, wrap old API shallowly around new API

2018-07-27 Thread Duy Nguyen
On Fri, Jul 27, 2018 at 2:40 AM Stefan Beller wrote: > > Currently the refs API takes a 'ref_store' as an argument to specify > which ref store to iterate over; however it is more useful to specify > the repository instead (or later a specific worktree of a repository). There is no 'later'.

[PATCH 2/3] refs: introduce new API, wrap old API shallowly around new API

2018-07-26 Thread Stefan Beller
Currently the refs API takes a 'ref_store' as an argument to specify which ref store to iterate over; however it is more useful to specify the repository instead (or later a specific worktree of a repository). Introduce a new API, that takes a repository struct instead of a ref store; the