Re: [PATCH 2/3] send-email: drop misleading function prototype

2013-03-31 Thread Eric Sunshine
On Sun, Mar 31, 2013 at 9:40 PM, Junio C Hamano wrote: > The subroutine check_file_rev_conflict() is called from two places, > both of which expects to pass a single scaler variable and see if s/scaler/scalar/g (note the /g) > that can be interpreted as a pathname or a revision name. It is > d

Re: [PATCH 2/3] send-email: drop misleading function prototype

2013-03-31 Thread Jonathan Nieder
Junio C Hamano wrote: > From: Ramkumar Ramachandra > > The subroutine check_file_rev_conflict() is called from two places, > both of which expects to pass a single scaler variable and see if > that can be interpreted as a pathname or a revision name. It is > defined with a function prototype ($)

[PATCH 2/3] send-email: drop misleading function prototype

2013-03-31 Thread Junio C Hamano
From: Ramkumar Ramachandra The subroutine check_file_rev_conflict() is called from two places, both of which expects to pass a single scaler variable and see if that can be interpreted as a pathname or a revision name. It is defined with a function prototype ($) to force a scaler context while e