Re: [PATCH 2/4] commit-slab.h: avoid -Wsign-compare warnings

2017-09-22 Thread Jeff King
On Fri, Sep 22, 2017 at 04:46:48PM +0100, Ramsay Jones wrote: > >> - int nth_slab, nth_slot; \ > >> + unsigned int nth_slab, nth_slot;\ > > > > I have a feeling that in the long run these should all be size_t, but > > it's

Re: [PATCH 2/4] commit-slab.h: avoid -Wsign-compare warnings

2017-09-22 Thread Ramsay Jones
On 22/09/17 06:29, Jeff King wrote: > On Thu, Sep 21, 2017 at 05:47:36PM +0100, Ramsay Jones wrote: > >> diff --git a/commit-slab.h b/commit-slab.h >> index 333d81e37..dcaab8ca0 100644 >> --- a/commit-slab.h >> +++ b/commit-slab.h >> @@ -78,7 +78,7 @@ static MAYBE_UNUSED void init_ ##slabname(st

Re: [PATCH 2/4] commit-slab.h: avoid -Wsign-compare warnings

2017-09-21 Thread Jeff King
On Thu, Sep 21, 2017 at 05:47:36PM +0100, Ramsay Jones wrote: > diff --git a/commit-slab.h b/commit-slab.h > index 333d81e37..dcaab8ca0 100644 > --- a/commit-slab.h > +++ b/commit-slab.h > @@ -78,7 +78,7 @@ static MAYBE_UNUSED void init_ ##slabname(struct slabname > *s) \ >

[PATCH 2/4] commit-slab.h: avoid -Wsign-compare warnings

2017-09-21 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- commit-slab.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/commit-slab.h b/commit-slab.h index 333d81e37..dcaab8ca0 100644 --- a/commit-slab.h +++ b/commit-slab.h @@ -78,7 +78,7 @@ static MAYBE_UNUSED void init_ ##slabname(struct slabn