Re: [PATCH 2/4] line-log: adjust start/end of ranges individually

2018-08-06 Thread Johannes Schindelin
Hi Eric, On Sun, 5 Aug 2018, Eric Sunshine wrote: > On Sat, Aug 4, 2018 at 6:18 PM Johannes Schindelin via GitGitGadget > wrote: > > When traversing commits and adjusting the ranges, things can get really > > tricky. For example, when the line range of interest encloses several > > hunks of a

Re: [PATCH 2/4] line-log: adjust start/end of ranges individually

2018-08-05 Thread Eric Sunshine
On Sun, Aug 5, 2018 at 6:14 AM Eric Sunshine wrote: > Having said that, a much easier fix is to use > range_set_append_unsafe() here, and then at the bottom of the loop, > invoke 'sort_and_merge_range_set(out)' to restore range-set invariants By "bottom", I meant "outside" or "after":

Re: [PATCH 2/4] line-log: adjust start/end of ranges individually

2018-08-05 Thread Eric Sunshine
On Sat, Aug 4, 2018 at 6:18 PM Johannes Schindelin via GitGitGadget wrote: > When traversing commits and adjusting the ranges, things can get really > tricky. For example, when the line range of interest encloses several > hunks of a commit, the line range can actually shrink. > > Currently,

[PATCH 2/4] line-log: adjust start/end of ranges individually

2018-08-04 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin When traversing commits and adjusting the ranges, things can get really tricky. For example, when the line range of interest encloses several hunks of a commit, the line range can actually shrink. Currently, range_set_shift_diff() does not anticipate that scenario and