[PATCH 2/4] peel_ref: do not return a null sha1

2012-10-04 Thread Jeff King
The idea of the peel_ref function is to dereference tag objects recursively until we hit a non-tag, and return the sha1. Conceptually, it should return 0 if it is successful (and fill in the sha1), or -1 if there was nothing to peel. However, the current behavior is much more confusing. For a regu

Re: [PATCH 2/4] peel_ref: do not return a null sha1

2012-10-04 Thread Junio C Hamano
Jeff King writes: > The idea of the peel_ref function is to dereference tag > objects recursively until we hit a non-tag, and return the > sha1. Conceptually, it should return 0 if it is successful > (and fill in the sha1), or -1 if there was nothing to peel. > > However, the current behavior is