Re: [PATCH 2/4] submodule: implement `module_name` as a builtin helper

2015-08-05 Thread Stefan Beller
On Tue, Aug 4, 2015 at 5:58 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Tue, Aug 4, 2015 at 8:04 PM, Stefan Beller sbel...@google.com wrote: The goal of this series being rewriting `git submodule update`, we don't want to call out to the shell script for config lookups. So reimplement

Re: [PATCH 2/4] submodule: implement `module_name` as a builtin helper

2015-08-05 Thread Jens Lehmann
Am 05.08.2015 um 02:04 schrieb Stefan Beller: The goal of this series being rewriting `git submodule update`, we don't want to call out to the shell script for config lookups. So reimplement the lookup of the submodule name in C. Cool. This brings down the duration of the test suite from 3:13

Re: [PATCH 2/4] submodule: implement `module_name` as a builtin helper

2015-08-05 Thread Stefan Beller
On Wed, Aug 5, 2015 at 12:06 PM, Jens Lehmann jens.lehm...@web.de wrote: Am 05.08.2015 um 02:04 schrieb Stefan Beller: The goal of this series being rewriting `git submodule update`, we don't want to call out to the shell script for config lookups. So reimplement the lookup of the submodule

Re: [PATCH 2/4] submodule: implement `module_name` as a builtin helper

2015-08-04 Thread Stefan Beller
The series consists of 2 patches only actually. The next patches have not been sent as they are heavy WIP. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/4] submodule: implement `module_name` as a builtin helper

2015-08-04 Thread Stefan Beller
The goal of this series being rewriting `git submodule update`, we don't want to call out to the shell script for config lookups. So reimplement the lookup of the submodule name in C. Signed-off-by: Stefan Beller sbel...@google.com --- When I started to implement git submodule add in the

Re: [PATCH 2/4] submodule: implement `module_name` as a builtin helper

2015-08-04 Thread Eric Sunshine
On Tue, Aug 4, 2015 at 8:04 PM, Stefan Beller sbel...@google.com wrote: The goal of this series being rewriting `git submodule update`, we don't want to call out to the shell script for config lookups. So reimplement the lookup of the submodule name in C. Signed-off-by: Stefan Beller