Re: [PATCH 2/4] t0024, t5000: use test_lazy_prereq for UNZIP

2013-01-07 Thread René Scharfe
Am 07.01.2013 09:45, schrieb Jonathan Nieder: René Scharfe wrote: --- a/t/t0024-crlf-archive.sh +++ b/t/t0024-crlf-archive.sh @@ -5,6 +5,11 @@ test_description='respect crlf in git archive' . ./test-lib.sh GIT_UNZIP=${GIT_UNZIP:-unzip} +test_lazy_prereq UNZIP ' + "$GIT_UNZIP" -v >/de

Re: [PATCH 2/4] t0024, t5000: use test_lazy_prereq for UNZIP

2013-01-07 Thread Jonathan Nieder
René Scharfe wrote: > --- a/t/t0024-crlf-archive.sh > +++ b/t/t0024-crlf-archive.sh > @@ -5,6 +5,11 @@ test_description='respect crlf in git archive' > . ./test-lib.sh > GIT_UNZIP=${GIT_UNZIP:-unzip} > > +test_lazy_prereq UNZIP ' > + "$GIT_UNZIP" -v >/dev/null 2>&1 > + test $? -ne 127

Re: [PATCH 2/4] t0024, t5000: use test_lazy_prereq for UNZIP

2013-01-06 Thread René Scharfe
Am 06.01.2013 19:06, schrieb Matt Kraai: On Sun, Jan 06, 2013 at 06:49:00PM +0100, René Scharfe wrote: This change makes the code smaller and we can put it at the top of the script, its rightful place as setup code. Would it be better to add the setting of GIT_UNZIP and test_lazy_prereq to tes

Re: [PATCH 2/4] t0024, t5000: use test_lazy_prereq for UNZIP

2013-01-06 Thread Matt Kraai
On Sun, Jan 06, 2013 at 06:49:00PM +0100, René Scharfe wrote: > This change makes the code smaller and we can put it at the top of > the script, its rightful place as setup code. Would it be better to add the setting of GIT_UNZIP and test_lazy_prereq to test-lib.sh so they aren't duplicated in bot

[PATCH 2/4] t0024, t5000: use test_lazy_prereq for UNZIP

2013-01-06 Thread René Scharfe
This change makes the code smaller and we can put it at the top of the script, its rightful place as setup code. Signed-off-by: Rene Scharfe --- t/t0024-crlf-archive.sh | 12 +--- t/t5000-tar-tree.sh | 12 +--- 2 files changed, 10 insertions(+), 14 deletions(-) diff --git a/