Re: [PATCH 2/4] t1000: modernize style

2017-01-10 Thread Junio C Hamano
Stefan Beller writes: > On Tue, Jan 10, 2017 at 12:37 PM, Junio C Hamano wrote: >> Stefan Beller writes: >> >>> The preferred style in tests seems to be >> >> s/seems to be/is/; > > If this is the only nit, mind to fix up the commit

Re: [PATCH 2/4] t1000: modernize style

2017-01-10 Thread Stefan Beller
On Tue, Jan 10, 2017 at 12:37 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> The preferred style in tests seems to be > > s/seems to be/is/; If this is the only nit, mind to fix up the commit message locally? (I was even unsure if we want to have

Re: [PATCH 2/4] t1000: modernize style

2017-01-10 Thread Junio C Hamano
Stefan Beller writes: > The preferred style in tests seems to be s/seems to be/is/; > > test_expect_success 'short description, ended by 2 single quotes' ' > here comes the test && > and chains over many lines && > ended by a quote > ' Thanks. This is

[PATCH 2/4] t1000: modernize style

2017-01-09 Thread Stefan Beller
The preferred style in tests seems to be test_expect_success 'short description, ended by 2 single quotes' ' here comes the test && and chains over many lines && ended by a quote ' Or going by the numbers: $ git -C t/ grep "' '$" | wc -l 9796 $ git -C t/ grep