Re: [PATCH 2/5] gitweb: Move check-ref-format code into separate function

2013-12-05 Thread Krzesimir Nowak
On Wed, 2013-12-04 at 12:31 -0800, Junio C Hamano wrote: Krzesimir Nowak krzesi...@endocode.com writes: This check will be used in more than one place later. Signed-off-by: Krzesimir Nowak krzesi...@endocode.com Reviewed-by: Junio C Hamano gits...@pobox.com Again, I do not think I

Re: [PATCH 2/5] gitweb: Move check-ref-format code into separate function

2013-12-05 Thread Krzesimir Nowak
On Wed, 2013-12-04 at 16:56 +0100, Jakub Narębski wrote: On Wed, Dec 4, 2013 at 2:43 PM, Krzesimir Nowak krzesi...@endocode.com wrote: This check will be used in more than one place later. Signed-off-by: Krzesimir Nowak krzesi...@endocode.com Reviewed-by: Junio C Hamano

Re: [PATCH 2/5] gitweb: Move check-ref-format code into separate function

2013-12-04 Thread Jakub Narębski
On Wed, Dec 4, 2013 at 2:43 PM, Krzesimir Nowak krzesi...@endocode.com wrote: This check will be used in more than one place later. Signed-off-by: Krzesimir Nowak krzesi...@endocode.com Reviewed-by: Junio C Hamano gits...@pobox.com Reviewed-by: Jakub Narębski jna...@gmail.com All right,

Re: [PATCH 2/5] gitweb: Move check-ref-format code into separate function

2013-12-04 Thread Junio C Hamano
Krzesimir Nowak krzesi...@endocode.com writes: This check will be used in more than one place later. Signed-off-by: Krzesimir Nowak krzesi...@endocode.com Reviewed-by: Junio C Hamano gits...@pobox.com Again, I do not think I reviewed this exact version. Nor did I say that use of the ... or