Re: [PATCH 2/5] pack-objects: take lock before accessing `remaining`

2017-08-15 Thread Johannes Sixt
Am 15.08.2017 um 14:53 schrieb Martin Ågren: When checking the conditional of "while (me->remaining)", we did not hold the lock. Calling find_deltas would still be safe, since it checks "remaining" (after taking the lock) and is able to handle all values. In fact, this could (currently) not

[PATCH 2/5] pack-objects: take lock before accessing `remaining`

2017-08-15 Thread Martin Ågren
When checking the conditional of "while (me->remaining)", we did not hold the lock. Calling find_deltas would still be safe, since it checks "remaining" (after taking the lock) and is able to handle all values. In fact, this could (currently) not trigger any bug: a bug could happen if `remaining`