Re: [PATCH 2/6] connect: uniformize and group CONNECT_DIAG_URL handling code

2016-05-02 Thread Junio C Hamano
Junio C Hamano writes: > Torsten Bögershausen writes: > >> git://host:[port]/path/to/repo >> Knowing that, the "@" will be feed into the name resolver, >> and that's OK. > > Is it OK? It is plausible that our client side may even want to > accept

Re: [PATCH 2/6] connect: uniformize and group CONNECT_DIAG_URL handling code

2016-05-02 Thread Junio C Hamano
Torsten Bögershausen writes: > git://host:[port]/path/to/repo > Knowing that, the "@" will be feed into the name resolver, > and that's OK. Is it OK? It is plausible that our client side may even want to accept git://user:pass@host:port/local/part, and as an anonymous service,

Re: [PATCH 2/6] connect: uniformize and group CONNECT_DIAG_URL handling code

2016-05-02 Thread Mike Hommey
On Mon, May 02, 2016 at 01:29:15PM +0200, Torsten Bögershausen wrote: > On 05/02/2016 10:31 AM, Mike Hommey wrote: > > On Mon, May 02, 2016 at 06:56:54AM +0200, Torsten Bögershausen wrote: > > > On 05/01/2016 08:02 AM, Mike Hommey wrote: > > > > + if (flags & CONNECT_DIAG_URL) { > > > >

Re: [PATCH 2/6] connect: uniformize and group CONNECT_DIAG_URL handling code

2016-05-02 Thread Torsten Bögershausen
On 05/02/2016 10:31 AM, Mike Hommey wrote: On Mon, May 02, 2016 at 06:56:54AM +0200, Torsten Bögershausen wrote: On 05/01/2016 08:02 AM, Mike Hommey wrote: + if (flags & CONNECT_DIAG_URL) { printf("Diag: url=%s\n", url ? url : "NULL"); printf("Diag:

Re: [PATCH 2/6] connect: uniformize and group CONNECT_DIAG_URL handling code

2016-05-02 Thread Mike Hommey
On Mon, May 02, 2016 at 06:56:54AM +0200, Torsten Bögershausen wrote: > On 05/01/2016 08:02 AM, Mike Hommey wrote: > > + if (flags & CONNECT_DIAG_URL) { > > printf("Diag: url=%s\n", url ? url : "NULL"); > > printf("Diag: protocol=%s\n", prot_name(protocol)); > >

Re: [PATCH 2/6] connect: uniformize and group CONNECT_DIAG_URL handling code

2016-05-01 Thread Torsten Bögershausen
On 05/01/2016 08:02 AM, Mike Hommey wrote: + if (flags & CONNECT_DIAG_URL) { printf("Diag: url=%s\n", url ? url : "NULL"); printf("Diag: protocol=%s\n", prot_name(protocol)); printf("Diag: hostandport=%s\n", hostandport ? hostandport :

Re: [PATCH 2/6] connect: uniformize and group CONNECT_DIAG_URL handling code

2016-05-01 Thread Mike Hommey
On Sun, May 01, 2016 at 03:37:24PM +0200, Torsten Bögershausen wrote: > I skipped the dates and names (I was responsible for one regression) > I hope this gives a half-correct overview, > why I am reluctant to change any code in connect.c > unless there is a fix for a real world problem. I don't

Re: [PATCH 2/6] connect: uniformize and group CONNECT_DIAG_URL handling code

2016-05-01 Thread Torsten Bögershausen
On 01.05.16 08:02, Mike Hommey wrote: > The CONNECT_DIAG_URL code for PROTO_GIT and PROTO_SSH were different in > subtle ways. Yes, and there (historical) reasons for that. The first implementation did support IPV6 with SSH: commit 5ba884483fe1a5f9ce1ce5e3c5e1c37c0fd296c4 [PATCH] GIT: Try

[PATCH 2/6] connect: uniformize and group CONNECT_DIAG_URL handling code

2016-05-01 Thread Mike Hommey
The CONNECT_DIAG_URL code for PROTO_GIT and PROTO_SSH were different in subtle ways. Those differences are not significant enough to justify the duplication of code, while this change also avoids starting to initialize a connection at all when handling CONNECT_DIAG_URL. This also moves the