Re: [PATCH 2/6] fsmonitor: Stop inline'ing mark_fsmonitor_valid / _invalid

2018-01-08 Thread Ben Peart
On 1/4/2018 5:27 PM, Johannes Schindelin wrote: Hi Alex, On Tue, 2 Jan 2018, Alex Vandiver wrote: These were inline'd when they were first introduced, presumably as an optimization for cases when they were called in tight loops. This complicates using these functions, as

Re: [PATCH 2/6] fsmonitor: Stop inline'ing mark_fsmonitor_valid / _invalid

2018-01-04 Thread Johannes Schindelin
Hi Alex, On Tue, 2 Jan 2018, Alex Vandiver wrote: > These were inline'd when they were first introduced, presumably as an > optimization for cases when they were called in tight loops. This > complicates using these functions, as untracked_cache_invalidate_path > is defined in dir.h. > > Leave