[PATCH 2/6] git-submodule.sh: rename unused variables

2018-07-18 Thread Stefan Beller
The 'mode' variable is not used in cmd_update for its original purpose, rename it to 'dummy' as it only serves the purpose to abort quickly documenting this knowledge. The variable 'stage' is also not used any more in cmd_update, so remove it. This went unnoticed as first each function used the

Re: [PATCH 2/6] git-submodule.sh: rename unused variables

2018-07-12 Thread Junio C Hamano
Stefan Beller writes: > The 'mode' variable is not used in cmd_update for its original purpose, > rename it to 'dummy' as it only serves the purpose to abort quickly > documenting this knowledge. It seems that (1) the while loop in git-submodule.sh we see in this patch is the only thing

[PATCH 2/6] git-submodule.sh: rename unused variables

2018-07-12 Thread Stefan Beller
The 'mode' variable is not used in cmd_update for its original purpose, rename it to 'dummy' as it only serves the purpose to abort quickly documenting this knowledge. The variable 'stage' is also not used any more in cmd_update, so remove it. This went unnoticed as first each function used the