Re: [PATCH 2/6] remote-http(s): Support SOCKS proxies

2015-11-17 Thread Junio C Hamano
Pat Thoyts writes: > A bit late to the party but 'yes'. Frankly by posting something to SO I > rather consider it public domain ... Unless otherwise noted, material posted on stackoverflow by default becomes CC-SA-BY (which may not be the best choice for open

Re: [PATCH 2/6] remote-http(s): Support SOCKS proxies

2015-11-16 Thread Johannes Schindelin
Hi Pat, On Mon, 9 Nov 2015, Pat Thoyts wrote: > Johannes Schindelin writes: > > >On Tue, 27 Oct 2015, Johannes Schindelin wrote: > > > >> On Mon, 26 Oct 2015, Junio C Hamano wrote: > >> > >> > James McCoy writes: > >> > > >> > >> The code

Re: [PATCH 2/6] remote-http(s): Support SOCKS proxies

2015-11-09 Thread Pat Thoyts
Johannes Schindelin writes: >Hi, > >On Tue, 27 Oct 2015, Johannes Schindelin wrote: > >> On Mon, 26 Oct 2015, Junio C Hamano wrote: >> >> > James McCoy writes: >> > >> > >> The code looks OK but the last paragraph makes _us_ worried. What >>

Re: [PATCH 2/6] remote-http(s): Support SOCKS proxies

2015-10-30 Thread Johannes Schindelin
Hi Junio, On Tue, 27 Oct 2015, Junio C Hamano wrote: > We are very lucky that the original was posted to SO by our friend > Pat, and you did the right thing to ask Pat to relicense. I suspect Pat is on a six month trip around the globe or something, judging from the feedback I got here:

Re: [PATCH 2/6] remote-http(s): Support SOCKS proxies

2015-10-27 Thread Johannes Schindelin
Hi, On Tue, 27 Oct 2015, Johannes Schindelin wrote: > On Mon, 26 Oct 2015, Junio C Hamano wrote: > > > James McCoy writes: > > > > >> The code looks OK but the last paragraph makes _us_ worried. What > > >> is the licensing status of the original at SO? > > > > > >

Re: [PATCH 2/6] remote-http(s): Support SOCKS proxies

2015-10-27 Thread Johannes Schindelin
Hi, On Mon, 26 Oct 2015, Junio C Hamano wrote: > James McCoy writes: > > >> The code looks OK but the last paragraph makes _us_ worried. What > >> is the licensing status of the original at SO? > > > > According to Stackoverflow[0], > > > > As noted in the Stack

Re: [PATCH 2/6] remote-http(s): Support SOCKS proxies

2015-10-27 Thread Junio C Hamano
Johannes Schindelin writes: > On second thought... Junio, could you please sanity-check my claim that > this patch: > > -- snip -- > ... > -- snap -- > > cannot be copyrighted because it is pretty much the only way to implement > said functionality? I am not a

Re: [PATCH 2/6] remote-http(s): Support SOCKS proxies

2015-10-27 Thread Junio C Hamano
Junio C Hamano writes: > Johannes Schindelin writes: > >> On second thought... Junio, could you please sanity-check my claim that >> this patch: >> >> -- snip -- >> ... >> -- snap -- >> >> cannot be copyrighted because it is pretty much the only

Re: [PATCH 2/6] remote-http(s): Support SOCKS proxies

2015-10-27 Thread Junio C Hamano
Junio C Hamano writes: > Analyzing copyrightability is often more costly than the risk. Misspelled, obviously: "more costly than the other ways to mitigate the risk" is what I meant. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to

Re: [PATCH 2/6] remote-http(s): Support SOCKS proxies

2015-10-26 Thread Junio C Hamano
Johannes Schindelin writes: > This patch was required to work behind a faulty AP and scraped from > http://stackoverflow.com/questions/15227130/#15228479 and guarded with > an appropriate cURL version check by Johannes Schindelin. > > Signed-off-by: Johannes

Re: [PATCH 2/6] remote-http(s): Support SOCKS proxies

2015-10-26 Thread James McCoy
On Mon, Oct 26, 2015 at 01:15:17PM -0700, Junio C Hamano wrote: > Johannes Schindelin writes: > > > This patch was required to work behind a faulty AP and scraped from > > http://stackoverflow.com/questions/15227130/#15228479 and guarded with > > an appropriate cURL

Re: [PATCH 2/6] remote-http(s): Support SOCKS proxies

2015-10-26 Thread Junio C Hamano
James McCoy writes: >> The code looks OK but the last paragraph makes _us_ worried. What >> is the licensing status of the original at SO? > > According to Stackoverflow[0], > > As noted in the Stack Exchange Terms of Service[1] and in the footer of > every page, all

[PATCH 2/6] remote-http(s): Support SOCKS proxies

2015-10-26 Thread Johannes Schindelin
From: Pat Thoyts With this patch we properly support SOCKS proxies, configured e.g. like this: git config http.proxy socks5://192.168.67.1:32767 Without this patch, Git mistakenly tries to use SOCKS proxies as if they were HTTP proxies, resulting in a