Re: [PATCH 2/6] sequencer: learn about the special "fake root commit" handling

2018-04-29 Thread Stefan Beller
Hi Johannes, thanks for taking your time to explain things. It shows I am not familiar with the rebase code, yet. > > Having said that, *this* time round, what we need to do is actually very > similar to what builtin/am.c's read_author_script() does (even if we > cannot use it as-is: it

Re: [PATCH 2/6] sequencer: learn about the special "fake root commit" handling

2018-04-29 Thread Johannes Schindelin
Hi Stefan, On Sat, 28 Apr 2018, Stefan Beller wrote: > On Fri, Apr 27, 2018 at 3:31 PM, Johannes Schindelin > wrote: > > When an interactive rebase wants to recreate a root commit, it > > - first creates a new, empty root commit, > > - checks it out, > > - converts

Re: [PATCH 2/6] sequencer: learn about the special "fake root commit" handling

2018-04-28 Thread Stefan Beller
On Fri, Apr 27, 2018 at 3:31 PM, Johannes Schindelin wrote: > When an interactive rebase wants to recreate a root commit, it > - first creates a new, empty root commit, > - checks it out, > - converts the next `pick` command so that it amends the empty root > commit

[PATCH 2/6] sequencer: learn about the special "fake root commit" handling

2018-04-27 Thread Johannes Schindelin
When an interactive rebase wants to recreate a root commit, it - first creates a new, empty root commit, - checks it out, - converts the next `pick` command so that it amends the empty root commit Introduce support in the sequencer to handle such an empty root commit, by looking for the file